Darko Poljak
3ead8b266a
Merge pull request #704 from thriqon/shellcheck-party-SC2069
...
Fix SC2069 (wrong stdout/stderr redirect order)
7 years ago
Jonas Weber
34b571b7d9
Fix SC2091 (execute result of condition)
...
For some reason, the echo|grep pattern was enclosed four times in a $()
operation. Nothing happened, since grep is always invoked with -q
(quiet, nothing printed to stdout).
7 years ago
Jonas Weber
bcd7fbbcc4
Fix SC2155 (directly export computed variables)
7 years ago
Jonas Weber
a0db375f91
Disable SC2059 (printf injection) for staged_file
...
We're explicitly allowing for 'printf injection' here, so it's ok to
just disable the corresponding shellcheck check.
7 years ago
Jonas Weber
a6fdf4255a
Fix SC2069 (wrong stdout/stderr redirect order)
...
In the original order, stderr was connected to the old stdout
(terminal). This was _probably_ not intended. The new order fixes this
by first connecting stdout to /dev/null and then attaching stderr to
that as well.
7 years ago
Jonas Weber
e2593c0dcb
Fix SC2215 (missing brackets on if)
...
This might have never worked as intended, but how would you know?
7 years ago
Jonas Weber
fff656d1ac
Unquote $recursive to support empty-case
...
This is safe to do, as the value of $recursive is not dependent on
user-supplied code.
7 years ago
Jonas Weber
53728a7ff0
Change backslash-dquote to single quote
...
Slightly breaking change, but improves security and readability.
7 years ago
Jonas Weber
ae7ccc5995
Fix SC2086 on all scripts
...
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086
relates to: #540
This commit addresses 241 separate cases of missing quotes around
variables.
7 years ago
Jonas Weber
23debd5b6f
Use cur_ip in jail for freebsd
7 years ago
Jonas Weber
352679386d
Drop unused options parameter in __install_reboot
7 years ago
Jonas Weber
b3f4d3849a
Fix __install_umount target parameter
7 years ago
Jonas Weber
6b0f8fba22
Remove unused variables (almost, found bugs?)
...
Solves SC2034
references #540 .
7 years ago
Darko Poljak
ef8ec8641e
++
7 years ago
Darko Poljak
a2ed14b6d0
Merge pull request #701 from tom-ee/fix-SC2148
...
fix SC2148 (missing shebang) and make executable
7 years ago
Thomas Eckert
085b2a2b10
remove `set -e` on explorers (they should be able to fail gracefully)
7 years ago
Thomas Eckert
a46da35bbc
fix SC2148 (missing shebang) and make executable
7 years ago
Darko Poljak
d49d38481f
++changelog
7 years ago
Darko Poljak
66ca2fcb70
Merge pull request #703 from tom-ee/fix-SC2045
...
fix SC2045 (use globs instead of `ls`)
7 years ago
Thomas Eckert
d950ddada3
fix SC2045 (use globs instead of `ls`)
7 years ago
Darko Poljak
31bf6ab230
++changelog
7 years ago
Darko Poljak
b62b41b263
Merge pull request #702 from tom-ee/fix-SC2166-global-explorer
...
fix another SC2166 (test `[ .. -a.. ]` replaced by `[ .. ] && ]`)
7 years ago
Thomas Eckert
134c84607f
fix another SC2166 (test `[ .. -a.. ]` replaced by `[ .. ] && ]`)
7 years ago
Darko Poljak
ab9e2264df
++changelog
7 years ago
Darko Poljak
e1b62ec560
Merge pull request #699 from darko-poljak/SC2039
...
Fix SC2039
7 years ago
Darko Poljak
383af6736f
++changelog
7 years ago
Darko Poljak
4403392869
Merge pull request #698 from darko-poljak/SC2002
...
Fix SC2002
7 years ago
Darko Poljak
8ef2773c0d
Fix SC2039
7 years ago
Darko Poljak
44acfcdd12
Fix SC2002
7 years ago
Darko Poljak
3757e8c2c5
++changelog
7 years ago
Darko Poljak
e69be05f70
Merge pull request #694 from darko-poljak/SC2005
...
Fix SC2005
7 years ago
Darko Poljak
d29534861b
Merge pull request #695 from darko-poljak/SC2004
...
Fix SC2004
7 years ago
Darko Poljak
0928708d19
Fix SC2004
7 years ago
Darko Poljak
5ed95ce93b
Fix SC2005
7 years ago
Darko Poljak
aef14ad39e
++changelog
7 years ago
Darko Poljak
f1369820d0
Merge pull request #693 from thriqon/shellcheck-party-SC2166
...
Fix SC2166 (and/or operators in test) on all manfest/gencode/explorers
7 years ago
Jonas Weber
6326eae1bb
Fix SC2166 on all manfest/gencode/explorers
7 years ago
Darko Poljak
e551348cd7
Create man7 directory if needed.
7 years ago
Darko Poljak
9cb9771e33
Exclude man7 empty directory from archive.
7 years ago
Darko Poljak
f705fe8fc6
Merge pull request #692 from darko-poljak/log-timestamping-config
...
Add timestamping log option to config file.
7 years ago
Darko Poljak
82077aff25
Add timestamping log option to config file.
7 years ago
Darko Poljak
e404ff4836
++changelog
7 years ago
Darko Poljak
1e34fc20be
Merge pull request #691 from darko-poljak/log-timestamping
...
Add timestamp to log messages.
7 years ago
Darko Poljak
c04325fdc5
++changelog
7 years ago
Darko Poljak
4b9994f134
Merge pull request #690 from myeisha/batch-scp
...
transfer all files of a directory at once
7 years ago
Darko Poljak
0c57b3083e
Fix getting loggers.
7 years ago
Darko Poljak
6acf6f64dc
Add timestamp to log messages.
7 years ago
Darko Poljak
02982ca8be
Release 4.10.3
7 years ago
Darko Poljak
1f703ab42e
++changelog
7 years ago
Darko Poljak
9b6ed0adc7
Merge pull request #689 from myeisha/deduplicate-mkdir
...
don't duplicate Remote::mkdir in explorer transfer
7 years ago