69790ec138
Fix typing error.
6 years ago
0458f66c96
Resolve SC2012.
6 years ago
ec186673bf
Add TODO markers for SC2012.
6 years ago
638ddd95d6
Fix problems found by sellcheck in type explorers.
6 years ago
334201b945
Fix remaining shellcheck problems.
6 years ago
e9b823bc39
Better fixes.
6 years ago
a78baccc82
Fix SC2154. Note: ignoring __<name> vars.
6 years ago
a9f27beb98
Fix SC1117.
6 years ago
83806e767a
Disable SC1091 where appropriate.
6 years ago
f039b0e6e5
Fix SC2030,SC2031.
6 years ago
68fad03a6b
Fix SC2120, SC2119.
6 years ago
b284bafbee
grep directly on the explorer file
6 years ago
02f39bcf6f
Fix SC2028.
6 years ago
0d80b4473b
Disable SC2031 for the single incident.
6 years ago
bf270b6f9c
Fix SC2044.
6 years ago
a369acea72
Fix SC2021.
6 years ago
644ec85d80
Fix SC2162.
6 years ago
16159d8fca
Fix SC2145.
6 years ago
596f3cf227
Disable SC2119,SC2120 where appropriate.
6 years ago
9b567ed8f7
Fix SC2230.
6 years ago
8cea8e67aa
Disable SC2031 where appropriate.
6 years ago
b120a813a2
Disable SC2030 where appropriate.
6 years ago
7b17ad4733
Fix SC2143.
6 years ago
e46420e7f5
Fix SC1090.
6 years ago
2f7b8e6db9
Fix SC2153.
6 years ago
73d0a5bbbe
Fix SC2235.
6 years ago
73acb35a8a
Fix SC2196.
6 years ago
28889ef38a
Disable SC2028 where intended.
6 years ago
ed542cc7cb
Fix SC2046.
6 years ago
b25aff17c6
Disable SC2039 where appropriate.
6 years ago
a601fa91d9
Fix SC2116.
6 years ago
3b6d759660
Disable SC2016 check.
6 years ago
c01cf38660
Fix SC2164
6 years ago
34b571b7d9
Fix SC2091 (execute result of condition)
...
For some reason, the echo|grep pattern was enclosed four times in a $()
operation. Nothing happened, since grep is always invoked with -q
(quiet, nothing printed to stdout).
6 years ago
bcd7fbbcc4
Fix SC2155 (directly export computed variables)
6 years ago
a0db375f91
Disable SC2059 (printf injection) for staged_file
...
We're explicitly allowing for 'printf injection' here, so it's ok to
just disable the corresponding shellcheck check.
6 years ago
a6fdf4255a
Fix SC2069 (wrong stdout/stderr redirect order)
...
In the original order, stderr was connected to the old stdout
(terminal). This was _probably_ not intended. The new order fixes this
by first connecting stdout to /dev/null and then attaching stderr to
that as well.
6 years ago
e2593c0dcb
Fix SC2215 (missing brackets on if)
...
This might have never worked as intended, but how would you know?
6 years ago
fff656d1ac
Unquote $recursive to support empty-case
...
This is safe to do, as the value of $recursive is not dependent on
user-supplied code.
6 years ago
53728a7ff0
Change backslash-dquote to single quote
...
Slightly breaking change, but improves security and readability.
6 years ago
ae7ccc5995
Fix SC2086 on all scripts
...
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086
relates to: #540
This commit addresses 241 separate cases of missing quotes around
variables.
6 years ago
23debd5b6f
Use cur_ip in jail for freebsd
6 years ago
352679386d
Drop unused options parameter in __install_reboot
6 years ago
b3f4d3849a
Fix __install_umount target parameter
6 years ago
6b0f8fba22
Remove unused variables (almost, found bugs?)
...
Solves SC2034
references #540 .
6 years ago
085b2a2b10
remove `set -e` on explorers (they should be able to fail gracefully)
6 years ago
a46da35bbc
fix SC2148 (missing shebang) and make executable
6 years ago
d950ddada3
fix SC2045 (use globs instead of `ls`)
6 years ago
134c84607f
fix another SC2166 (test `[ .. -a.. ]` replaced by `[ .. ] && ]`)
6 years ago
8ef2773c0d
Fix SC2039
6 years ago
Darko Poljak